Bug 117595

Summary: Refactor ObjCCallbackFunction to inherit directly from InternalFunction
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117594    
Attachments:
Description Flags
Patch ggaren: review+

Mark Hahnenberg
Reported 2013-06-13 08:51:13 PDT
As part of bug 117594, we need to get ObjCCallbackFunction to inherit from InternalFunction rather than JSCallbackFunction.
Attachments
Patch (15.65 KB, patch)
2013-06-13 09:03 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-06-13 09:03:42 PDT
Created attachment 204600 [details] Patch
Geoffrey Garen
Comment 2 2013-06-13 10:30:32 PDT
Comment on attachment 204600 [details] Patch r=me
Geoffrey Garen
Comment 3 2013-06-13 10:31:06 PDT
At some point, we'll probably want to split the API folder in c and objc sub-folders. "API" is a slightly ambiguous prefix now.
Mark Hahnenberg
Comment 4 2013-06-13 12:17:07 PDT
(In reply to comment #3) > At some point, we'll probably want to split the API folder in c and objc sub-folders. "API" is a slightly ambiguous prefix now. That sounds like a good thing to do as part of my refactoring rampage. I picked APIFunctionCallback to indicate that it's a general struct used in both the C and Obj-C APIs.
Mark Hahnenberg
Comment 5 2013-06-19 13:09:58 PDT
Committed r151749: <http://trac.webkit.org/changeset/151749>
Note You need to log in before you can comment on or make changes to this bug.