Bug 11759

Summary: Windows build bustage
Product: WebKit Reporter: Don Gibson <dgibson77>
Component: WebCore Misc.Assignee: Don Gibson <dgibson77>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch for r18020
none
patch for r18084 ap: review+

Description Don Gibson 2006-12-05 11:26:26 PST
Patch coming shortly
Comment 1 Don Gibson 2006-12-05 11:29:29 PST
Created attachment 11741 [details]
patch for r18020

Gets windows compiling again, but the resource loader is pretty screwed up.  Trying to load a page results in a crash due to the ResourceHandle's client() (a SubresourceLoader) being garbage.  Someone isn't holding a reference long enough.  Since that stuff is all highly in flux right now, I don't care enough to fix it.
Comment 2 Don Gibson 2006-12-08 13:20:28 PST
Created attachment 11777 [details]
patch for r18084

Updated to newest trunk
Comment 3 Alexey Proskuryakov 2006-12-08 13:30:09 PST
Comment on attachment 11777 [details]
patch for r18084

Looks sane, r=me.

+        virtual void downloadURL(const KURL& url);

This doesn't need a variable name in the header.
Comment 4 Alexey Proskuryakov 2006-12-08 13:34:19 PST
Committed revision 18086.