Bug 11759 - Windows build bustage
Summary: Windows build bustage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Don Gibson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-05 11:26 PST by Don Gibson
Modified: 2006-12-08 13:34 PST (History)
0 users

See Also:


Attachments
patch for r18020 (9.17 KB, patch)
2006-12-05 11:29 PST, Don Gibson
no flags Details | Formatted Diff | Diff
patch for r18084 (21.82 KB, patch)
2006-12-08 13:20 PST, Don Gibson
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Gibson 2006-12-05 11:26:26 PST
Patch coming shortly
Comment 1 Don Gibson 2006-12-05 11:29:29 PST
Created attachment 11741 [details]
patch for r18020

Gets windows compiling again, but the resource loader is pretty screwed up.  Trying to load a page results in a crash due to the ResourceHandle's client() (a SubresourceLoader) being garbage.  Someone isn't holding a reference long enough.  Since that stuff is all highly in flux right now, I don't care enough to fix it.
Comment 2 Don Gibson 2006-12-08 13:20:28 PST
Created attachment 11777 [details]
patch for r18084

Updated to newest trunk
Comment 3 Alexey Proskuryakov 2006-12-08 13:30:09 PST
Comment on attachment 11777 [details]
patch for r18084

Looks sane, r=me.

+        virtual void downloadURL(const KURL& url);

This doesn't need a variable name in the header.
Comment 4 Alexey Proskuryakov 2006-12-08 13:34:19 PST
Committed revision 18086.