Bug 117578

Summary: Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set
Product: WebKit Reporter: Praveen Jadhav <praveen.j>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, crogers, dev_sachin, eric.carlson, glenn, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Praveen Jadhav
Reported 2013-06-12 23:39:28 PDT
In current WebKit code, callOnMainThread() is called always even though 'onaudioprocess' listener is not set in ScriptProcessorNode.
Attachments
Patch (3.82 KB, patch)
2013-06-12 23:53 PDT, Praveen Jadhav 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Praveen Jadhav
Comment 1 2013-06-12 23:53:06 PDT
Created attachment 204557 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-13 10:03:31 PDT
Comment on attachment 204557 [details] Patch Clearing flags on attachment: 204557 Committed r151558: <http://trac.webkit.org/changeset/151558>
WebKit Commit Bot
Comment 3 2013-06-13 10:03:34 PDT
All reviewed patches have been landed. Closing bug.
Chris Rogers
Comment 4 2013-06-13 10:21:13 PDT
Comment on attachment 204557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204557&action=review > Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:145 > + return; you need to call zero() on outputBus before returning to make sure you're producing silence
Note You need to log in before you can comment on or make changes to this bug.