Summary: | [EFL][WK1] Some tests of editing/selection fail to render properly | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, lucas.de.marchi | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-06-12 18:04:12 PDT
Created attachment 215727 [details]
Patch
Comment on attachment 215727 [details]
Patch
Thank you.
For your information,
"Unreviewed" means that you don't need to get r+.
Instead, you should ask cq? to get cq+.
If you are using webkit-patch,
you can use --no-review --request-commit option
Comment on attachment 215727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215727&action=review > LayoutTests/ChangeLog:3 > + [EFL] Need to update the EFL test expectations. Different bug title with existing one. > LayoutTests/platform/efl-wk1/TestExpectations:117 > webkit.org/b/117574 editing/selection/caret-and-focus-ring.html [ ImageOnlyFailure ] Please change this bug url using a bug you filed. This bug will be "Resolved Fixed." Created attachment 215847 [details]
Patch
Comment on attachment 215847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215847&action=review > LayoutTests/platform/efl-wk1/TestExpectations:485 > + Do not add unnecessary line. Created attachment 215851 [details]
Patch
Created attachment 215852 [details]
Patch
Comment on attachment 215852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215852&action=review > LayoutTests/ChangeLog:11 > + Unreviewed, EFL gardening. Generally, patch description is placed below this line. Created attachment 215854 [details]
Patch
Comment on attachment 215854 [details] Patch Clearing flags on attachment: 215854 Committed r158532: <http://trac.webkit.org/changeset/158532> All reviewed patches have been landed. Closing bug. |