WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
117574
[EFL][WK1] Some tests of editing/selection fail to render properly
https://bugs.webkit.org/show_bug.cgi?id=117574
Summary
[EFL][WK1] Some tests of editing/selection fail to render properly
Gyuyoung Kim
Reported
2013-06-12 18:04:12 PDT
Draw the wrong patterns in comparison to the EFL-WK2. editing/selection/3690703-2.html editing/selection/3690703.html editing/selection/3690719.html editing/selection/4397952.html editing/selection/4895428-3.html editing/selection/4975120.html editing/selection/5007143-2.html editing/selection/5007143.html editing/selection/5057506.html editing/selection/5195166-1.html editing/selection/7152-2.html editing/selection/caret-and-focus-ring.html editing/selection/caret-before-select.html editing/selection/caret-ltr-right.html editing/selection/caret-rtl-2-left.html editing/selection/caret-rtl-right.html
Attachments
Patch
(4.12 KB, patch)
2013-11-01 02:46 PDT
,
Sun-woo Nam
no flags
Details
Formatted Diff
Diff
Patch
(4.71 KB, patch)
2013-11-03 00:25 PDT
,
Sun-woo Nam
no flags
Details
Formatted Diff
Diff
Patch
(4.71 KB, patch)
2013-11-03 00:57 PDT
,
Sun-woo Nam
no flags
Details
Formatted Diff
Diff
Patch
(4.29 KB, patch)
2013-11-03 01:07 PST
,
Sun-woo Nam
no flags
Details
Formatted Diff
Diff
Patch
(4.29 KB, patch)
2013-11-03 01:24 PST
,
Sun-woo Nam
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Sun-woo Nam
Comment 1
2013-11-01 02:46:56 PDT
Created
attachment 215727
[details]
Patch
Ryuan Choi
Comment 2
2013-11-01 02:57:31 PDT
Comment on
attachment 215727
[details]
Patch Thank you. For your information, "Unreviewed" means that you don't need to get r+. Instead, you should ask cq? to get cq+. If you are using webkit-patch, you can use --no-review --request-commit option
Gyuyoung Kim
Comment 3
2013-11-01 03:13:33 PDT
Comment on
attachment 215727
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=215727&action=review
> LayoutTests/ChangeLog:3 > + [EFL] Need to update the EFL test expectations.
Different bug title with existing one.
> LayoutTests/platform/efl-wk1/TestExpectations:117 >
webkit.org/b/117574
editing/selection/caret-and-focus-ring.html [ ImageOnlyFailure ]
Please change this bug url using a bug you filed. This bug will be "Resolved Fixed."
Sun-woo Nam
Comment 4
2013-11-03 00:25:44 PDT
Created
attachment 215847
[details]
Patch
Gyuyoung Kim
Comment 5
2013-11-03 00:27:13 PDT
Comment on
attachment 215847
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=215847&action=review
> LayoutTests/platform/efl-wk1/TestExpectations:485 > +
Do not add unnecessary line.
Sun-woo Nam
Comment 6
2013-11-03 00:57:06 PDT
Created
attachment 215851
[details]
Patch
Sun-woo Nam
Comment 7
2013-11-03 01:07:32 PST
Created
attachment 215852
[details]
Patch
Gyuyoung Kim
Comment 8
2013-11-03 01:09:21 PST
Comment on
attachment 215852
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=215852&action=review
> LayoutTests/ChangeLog:11 > + Unreviewed, EFL gardening.
Generally, patch description is placed below this line.
Sun-woo Nam
Comment 9
2013-11-03 01:24:04 PST
Created
attachment 215854
[details]
Patch
WebKit Commit Bot
Comment 10
2013-11-03 06:53:57 PST
Comment on
attachment 215854
[details]
Patch Clearing flags on attachment: 215854 Committed
r158532
: <
http://trac.webkit.org/changeset/158532
>
WebKit Commit Bot
Comment 11
2013-11-03 06:54:00 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug