Bug 117574 - [EFL][WK1] Some tests of editing/selection fail to render properly
Summary: [EFL][WK1] Some tests of editing/selection fail to render properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 18:04 PDT by Gyuyoung Kim
Modified: 2013-11-03 06:54 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2013-11-01 02:46 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (4.71 KB, patch)
2013-11-03 00:25 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (4.71 KB, patch)
2013-11-03 00:57 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (4.29 KB, patch)
2013-11-03 01:07 PST, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (4.29 KB, patch)
2013-11-03 01:24 PST, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-06-12 18:04:12 PDT 
Draw the wrong patterns in comparison to the EFL-WK2.

editing/selection/3690703-2.html
editing/selection/3690703.html
editing/selection/3690719.html
editing/selection/4397952.html
editing/selection/4895428-3.html
editing/selection/4975120.html
editing/selection/5007143-2.html
editing/selection/5007143.html
editing/selection/5057506.html
editing/selection/5195166-1.html
editing/selection/7152-2.html
editing/selection/caret-and-focus-ring.html
editing/selection/caret-before-select.html
editing/selection/caret-ltr-right.html
editing/selection/caret-rtl-2-left.html
editing/selection/caret-rtl-right.html
Comment 1 Sun-woo Nam 2013-11-01 02:46:56 PDT 
Created attachment 215727 [details]
Patch
Comment 2 Ryuan Choi 2013-11-01 02:57:31 PDT 
Comment on attachment 215727 [details]
Patch

Thank you.

For your information,
"Unreviewed" means that you don't need to get r+.

Instead, you should ask cq? to get cq+.

If you are using webkit-patch,
you can use --no-review --request-commit option
Comment 3 Gyuyoung Kim 2013-11-01 03:13:33 PDT 
Comment on attachment 215727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215727&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] Need to update the EFL test expectations.

Different bug title with existing one.

> LayoutTests/platform/efl-wk1/TestExpectations:117
>  webkit.org/b/117574 editing/selection/caret-and-focus-ring.html [ ImageOnlyFailure ]

Please change this bug url using a bug you filed. This bug will be "Resolved Fixed."
Comment 4 Sun-woo Nam 2013-11-03 00:25:44 PDT 
Created attachment 215847 [details]
Patch
Comment 5 Gyuyoung Kim 2013-11-03 00:27:13 PDT 
Comment on attachment 215847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215847&action=review

> LayoutTests/platform/efl-wk1/TestExpectations:485
> +

Do not add unnecessary line.
Comment 6 Sun-woo Nam 2013-11-03 00:57:06 PDT 
Created attachment 215851 [details]
Patch
Comment 7 Sun-woo Nam 2013-11-03 01:07:32 PST 
Created attachment 215852 [details]
Patch
Comment 8 Gyuyoung Kim 2013-11-03 01:09:21 PST 
Comment on attachment 215852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215852&action=review

> LayoutTests/ChangeLog:11
> +        Unreviewed, EFL gardening.

Generally, patch description is placed below this line.
Comment 9 Sun-woo Nam 2013-11-03 01:24:04 PST 
Created attachment 215854 [details]
Patch
Comment 10 WebKit Commit Bot 2013-11-03 06:53:57 PST 
Comment on attachment 215854 [details]
Patch

Clearing flags on attachment: 215854

Committed r158532: <http://trac.webkit.org/changeset/158532>
Comment 11 WebKit Commit Bot 2013-11-03 06:54:00 PST 
All reviewed patches have been landed.  Closing bug.