Bug 117566 – [CSS Regions] -webkit-background-clip: text; does not clip the background in regions

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Max Vujovic]

Patch with test case coming up!

[Max Vujovic]

Created attachment 204544 [details]
Patch

[Alexandru Chiculita]

Comment on attachment 204544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204544&action=review

r=me

> Source/WebCore/rendering/RenderFlowThread.cpp:306
> +        PaintBehavior paintBehavior = 0;

nit: I know that you are going to do selection phase, too. Usually we would have written this in one single line using the ?: operator.

[Build Bot]

Comment on attachment 204544 [details]
Patch

Attachment 204544 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/847086

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html

[Build Bot]

Created attachment 204562 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Max Vujovic]

(In reply to comment #3)
> (From update of attachment 204544 [details])
> Attachment 204544 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/847086
> 
> New failing tests:
> http/tests/security/cross-origin-plugin-private-browsing-toggled.html

This failure looks unrelated and doesn't repro locally.

[Max Vujovic]

Comment on attachment 204544 [details]
Patch

Setting cq+.

[Max Vujovic]

(In reply to comment #2)
> (From update of attachment 204544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204544&action=review
> 
> r=me
> 
> > Source/WebCore/rendering/RenderFlowThread.cpp:306
> > +        PaintBehavior paintBehavior = 0;
> 
> nit: I know that you are going to do selection phase, too. Usually we would have written this in one single line using the ?: operator.

Yup, I'm working on the selection phase patch right now :)

[WebKit Commit Bot]

Comment on attachment 204544 [details]
Patch

Clearing flags on attachment: 204544

Committed r151555: <http://trac.webkit.org/changeset/151555>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.