Bug 117564

Summary: [GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
Product: WebKit Reporter: Hugo Parente Lima <hugo.lima>
Component: WebKitGTKAssignee: Hugo Parente Lima <hugo.lima>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Hugo Parente Lima
Reported 2013-06-12 15:32:15 PDT
This compilation problem happen if you try to use libcurl as network backend because glib.h isn't included by libcurl headers. I know the official and only one supported network backend for GTK port is libSoup, anyway it's a error to not directly include the glib header where using their types besides this help whom are doing tests with libcurl :-)
Attachments
Patch (1.28 KB, patch)
2013-06-12 15:34 PDT, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1 2013-06-12 15:34:23 PDT
Created attachment 204539 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-12 16:53:13 PDT
Comment on attachment 204539 [details] Patch Clearing flags on attachment: 204539 Committed r151527: <http://trac.webkit.org/changeset/151527>
WebKit Commit Bot
Comment 3 2013-06-12 16:53:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.