Bug 117562

Summary: Headers and footers should be pinned to the left edge of the window when scrolling horizontally, even when zoomed
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, jamesr, luiz, sam, simon.fraser, tonikitoo
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Beth Dakin
Reported 2013-06-12 14:50:27 PDT
http://trac.webkit.org/changeset/150043 made headers and footers stay pinned to the left edge when scrolling horizontally, but the bug still occurs when you are scrolled horizontally and zoomed in. Patch forthcoming. <rdar://problem/14006745>
Attachments
Patch (2.38 KB, patch)
2013-06-12 15:40 PDT, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-06-12 15:40:43 PDT
Created attachment 204540 [details] Patch
Sam Weinig
Comment 2 2013-06-13 11:09:10 PDT
Comment on attachment 204540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204540&action=review > Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:321 > + float horizontalScrollOffsetForBanner = scrollOffsetForFixedChildren.width(); > + if (frameScaleFactor() != 1) > + horizontalScrollOffsetForBanner = FrameView::scrollOffsetForFixedPosition(viewportRect(), totalContentsSize(), position, scrollOrigin(), 1, false, headerHeight(), footerHeight()).width(); > + This could use a comment. It is confusing enough.
Beth Dakin
Comment 3 2013-06-13 11:23:04 PDT
Comment added! Thank you! http://trac.webkit.org/changeset/151564
Note You need to log in before you can comment on or make changes to this bug.