Bug 117559

Summary: fourthTier: DFG should support op_switch_imm
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
the patch
none
the patch
none
the patch oliver: review+

Filip Pizlo
Reported 2013-06-12 12:53:52 PDT
Patch forthcoming.
Attachments
work in progress (28.87 KB, patch)
2013-06-12 12:57 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (42.88 KB, patch)
2013-06-13 11:29 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (43.29 KB, patch)
2013-06-13 11:32 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (46.76 KB, patch)
2013-06-13 13:56 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-06-12 12:57:15 PDT
Created attachment 204501 [details] work in progress I still have more gluing to do before it works, but it's getting there.
Filip Pizlo
Comment 2 2013-06-13 11:29:56 PDT
Created attachment 204631 [details] the patch
Filip Pizlo
Comment 3 2013-06-13 11:32:47 PDT
Created attachment 204634 [details] the patch Added more to the changelog.
Filip Pizlo
Comment 4 2013-06-13 11:34:35 PDT
Comment on attachment 204634 [details] the patch Ha! Forgot all about 32-bit.
Filip Pizlo
Comment 5 2013-06-13 13:56:35 PDT
Created attachment 204640 [details] the patch For real this time.
Michael Saboff
Comment 6 2013-06-13 15:02:15 PDT
Comment on attachment 204640 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204640&action=review How hard would it be to put the edge code removal in a separate patch? > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2719 > + nit - delete the white space
Filip Pizlo
Comment 7 2013-06-13 15:47:17 PDT
(In reply to comment #6) > (From update of attachment 204640 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204640&action=review > > How hard would it be to put the edge code removal in a separate patch? > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2719 > > + > > nit - delete the white space Done!
Filip Pizlo
Comment 8 2013-06-15 15:37:31 PDT
Landed in http://trac.webkit.org/changeset/151616
Note You need to log in before you can comment on or make changes to this bug.