Bug 117535

Summary:

[Qt] Set windows key-code for multimedia keys

Product:

WebKit

Reporter:

Allan Sandfeld Jensen <allan.jensen>

Component:

UI Events

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, jturcotte

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jturcotte: review+

Description Allan Sandfeld Jensen 2013-06-12 03:27:08 PDT

We do not currently set the windows keycode for generated key events for multimedia keys. Some of them do have well-defined values though.

Comment 1 Allan Sandfeld Jensen 2013-06-12 03:28:49 PDT

Created attachment 204423 [details]
Patch

Comment 2 Jocelyn Turcotte 2013-06-12 03:48:03 PDT

Comment on attachment 204423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204423&action=review

> Source/WebCore/platform/qt/PlatformKeyboardEventQt.cpp:439
>          // VK_VOLUME_MUTE (AD) Windows 2000/XP: Volume Mute key
> +    case Qt::Key_VolumeMute:
> +        return VK_VOLUME_MUTE;

Part of the file moves the comment after the value and remove the name in the comment.
return VK_VOLUME_MUTE; // (AD) Windows 2000/XP: Volume Mute key

I think it would be easier to read (slightly).
r=me for the rest.

Comment 3 Allan Sandfeld Jensen 2013-06-12 04:44:48 PDT

Committed r151494: <http://trac.webkit.org/changeset/151494>