Bug 117535 - [Qt] Set windows key-code for multimedia keys
Summary: [Qt] Set windows key-code for multimedia keys
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-12 03:27 PDT by Allan Sandfeld Jensen
Modified: 2013-06-12 04:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2013-06-12 03:28 PDT, Allan Sandfeld Jensen 		jturcotte: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-06-12 03:27:08 PDT 
We do not currently set the windows keycode for generated key events for multimedia keys. Some of them do have well-defined values though.
Comment 1 Allan Sandfeld Jensen 2013-06-12 03:28:49 PDT 
Created attachment 204423 [details]
Patch
Comment 2 Jocelyn Turcotte 2013-06-12 03:48:03 PDT 
Comment on attachment 204423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204423&action=review

> Source/WebCore/platform/qt/PlatformKeyboardEventQt.cpp:439
>          // VK_VOLUME_MUTE (AD) Windows 2000/XP: Volume Mute key
> +    case Qt::Key_VolumeMute:
> +        return VK_VOLUME_MUTE;

Part of the file moves the comment after the value and remove the name in the comment.
return VK_VOLUME_MUTE; // (AD) Windows 2000/XP: Volume Mute key

I think it would be easier to read (slightly).
r=me for the rest.
Comment 3 Allan Sandfeld Jensen 2013-06-12 04:44:48 PDT 
Committed r151494: <http://trac.webkit.org/changeset/151494>