Bug 117520

Summary: remove existing CodeCoverage tool
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, sam
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch sam: review+, commit-queue: commit-queue-

Alex Christensen
Reported 2013-06-11 13:25:46 PDT
The existing Tools/CodeCoverage directory contains code that doesn't work, hasn't been touched in 4-6 years, and needs improvements. I'm working on a new code coverage/code heat tool that will replace this, but I suggest the old one be removed before adding the new one (which is still in the works).
Attachments
Patch (36.04 KB, patch)
2013-06-11 13:27 PDT, Alex Christensen 		sam: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-06-11 13:27:34 PDT
Created attachment 204355 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-11 14:16:31 PDT
Comment on attachment 204355 [details] Patch Rejecting attachment 204355 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 204355, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: m bug 117520. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Did not find end of header block corresponding to index path "Tools/CodeCoverage/snow.png". at /Volumes/Data/EWS/WebKit/Tools/Scripts/VCSUtils.pm line 880, <ARGV> line 1033. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/738512
Alex Christensen
Comment 3 2013-06-11 14:24:25 PDT
I committed this manually. r151472
Alex Christensen
Comment 4 2013-08-20 09:03:45 PDT
r151474
Note You need to log in before you can comment on or make changes to this bug.