Bug 117504

Summary:

[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.

Product:

WebKit

Reporter:

Changhyup Jwa <ch.jwa>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, ostap73, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Changhyup Jwa 2013-06-11 03:31:06 PDT

Ewk2 unit test fails if ecore_evas_new() fails return Ecore_Evas* in EWK2UnitTestBase::SetUp().
Here's the logs when ecore_evas_new() is failed.

ERR<28903>:ecore_evas ecore_evas_x.c:254 _ecore_evas_x_gl_window_new() evas_engine_info_set() for engine 'opengl_x11' failed.

It's a same solution with https://bugs.webkit.org/show_bug.cgi?id=102704

Comment 1 Changhyup Jwa 2013-06-11 03:47:37 PDT

Created attachment 204335 [details]
Patch

Comment 2 Chris Dumez 2013-06-11 04:46:18 PDT

Comment on attachment 204335 [details]
Patch

Looks fine. r=me.

Comment 3 WebKit Commit Bot 2013-06-11 05:12:38 PDT

Comment on attachment 204335 [details]
Patch

Clearing flags on attachment: 204335

Committed r151433: <http://trac.webkit.org/changeset/151433>

Comment 4 WebKit Commit Bot 2013-06-11 05:12:41 PDT

All reviewed patches have been landed.  Closing bug.