Bug 117492

Summary:	Get rid of extraneous accessibility tree traversal code
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Accessibility	Assignee:	chris fleizach <cfleizach>
Status:	ASSIGNED ---
Severity:	Normal	CC:	cfleizach, darin, mrobinson, webkit-bug-importer
Priority:	P2	Keywords:	BlinkMergeCandidate, InRadar
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Description Ryosuke Niwa 2013-06-10 22:59:07 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/dc0367e0c01205a6c9289e35260ca46ae4f86566

We never used AccessibilityRenderObject::previousSibling, and
I've been scared for a long time someone would accidentally
use it and we'd discover it's full of bugs, since it had no
test coverage. (Several bugs have been caught in nextSibling over
the years.) Time for it to die.

We also don't need AccessibilityObject::lastChild, though
the implementation was trivial.

The public interface needs even less - we can get rid of
firstChild, lastChild, nextSibling, and previousSibling,
because childAt is the only one called.

Comment 1 chris fleizach 2013-06-10 23:44:26 PDT

good idea

Comment 2 Radar WebKit Bug Importer 2014-02-07 11:35:01 PST

<rdar://problem/16014110>