Bug 117492 - Get rid of extraneous accessibility tree traversal code
Summary: Get rid of extraneous accessibility tree traversal code
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Blocks:
 
Reported: 2013-06-10 22:59 PDT by Ryosuke Niwa
Modified: 2014-02-07 11:35 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-10 22:59:07 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/dc0367e0c01205a6c9289e35260ca46ae4f86566

We never used AccessibilityRenderObject::previousSibling, and
I've been scared for a long time someone would accidentally
use it and we'd discover it's full of bugs, since it had no
test coverage. (Several bugs have been caught in nextSibling over
the years.) Time for it to die.

We also don't need AccessibilityObject::lastChild, though
the implementation was trivial.

The public interface needs even less - we can get rid of
firstChild, lastChild, nextSibling, and previousSibling,
because childAt is the only one called.
Comment 1 chris fleizach 2013-06-10 23:44:26 PDT
good idea
Comment 2 Radar WebKit Bug Importer 2014-02-07 11:35:01 PST
<rdar://problem/16014110>