Bug 117484

Summary:

Simplify AccessibilityText

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

ASSIGNED

Severity:

Normal

CC:

ahmad.saleem792, benjamin, cfleizach, kling, koivisto, naserid13, samuel_white, webkit-bug-importer

Priority:

Keywords:

BlinkMergeCandidate, InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
http://www.bugs.webkit.org	cfleizach: review-

Ryosuke Niwa

Reported 2013-06-10 21:20:55 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/b76d6a339c94502c25b74dbfb5516cf20b522c07 The AccessibilityText struct had a vector of node references, when a single reference is suffices since AccessibilityText itself is repeated. This removes a ton of code from every function that uses AccessibilityText.

Attachments
http://www.bugs.webkit.org (30.30 KB, patch) 2016-06-12 17:22 PDT, Abu Naser Saifullah	cfleizach: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2013-06-10 23:53:42 PDT

I think this change breaks ariaLabeledByText() because they're appending a new text object for each element instead of concatenating them like they need to be. however, i don't know if the elements are even necessary. i don't see them being re-used. I think we could just allow a pointer to an element because there's probably not a great reason to reference the elements after the string is made however, i think we might also have bugs that ask us to actually return the elements in aria-labeledby so the screen reader can query those elements

chris fleizach

Comment 2 2013-06-10 23:53:58 PDT

We should look into this to evaluate

Radar WebKit Bug Importer

Comment 3 2014-02-07 11:33:51 PST

<rdar://problem/16014103>

Abu Naser Saifullah

Comment 4 2016-06-12 17:22:49 PDT

Created attachment 281135 [details] http://www.bugs.webkit.org

chris fleizach

Comment 5 2016-06-12 22:40:27 PDT

Comment on attachment 281135 [details] http://www.bugs.webkit.org Don't know what this is.. Spam?

Ahmad Saleem

Comment 6 2022-09-30 18:34:27 PDT

I think it has been simplified but it is still using Vector rather than RefPtr: https://github.com/WebKit/WebKit/blob/61b68425a2b484f2680d340ca998c38395d8d5fd/Source/WebCore/accessibility/AccessibilityNodeObject.cpp#L1839 Plus this commit removed "textElement" bits: https://github.com/WebKit/WebKit/commit/f8283a7eece23958929380c652cebb7e7d302244 Is this needed anymore? Thanks!

Note You need to log in before you can comment on or make changes to this bug.