[EFL][WK2] Add ewk_view_navigate API

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

Patch will be added.

[Ryuan Choi]

Created attachment 204276 [details]
Patch

[Chris Dumez]

Comment on attachment 204276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204276&action=review

> Source/WebKit2/ChangeLog:11
> +        (EwkBackForwardListItem::wkItem): Return WKBackForwardListItemRef for pate to navigate.

pate -> page

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:314
> +Eina_Bool ewk_view_navigate(Evas_Object* ewkView, int steps)

The application usually wants to navigate to a history item (i.e. back forward list item), not using a number of steps. I think this API should take a Ewk_Back_Forward_List_Item in argument and maybe rename to "ewk_view_navigate_to()".

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 204276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204276&action=review
> 
> > Source/WebKit2/ChangeLog:11
> > +        (EwkBackForwardListItem::wkItem): Return WKBackForwardListItemRef for pate to navigate.
> 
> pate -> page
> 

Oops, sorry I will fix it.

> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:314
> > +Eina_Bool ewk_view_navigate(Evas_Object* ewkView, int steps)
> 
> The application usually wants to navigate to a history item (i.e. back forward list item), not using a number of steps. I think this API should take a Ewk_Back_Forward_List_Item in argument and maybe rename to "ewk_view_navigate_to()".

It depends on application developers but make sense.

I choosed steps because I still consider consistency of legacy(ewebkit1 and elm_web).

I will update like you mentioned.

[Ryuan Choi]

Created attachment 204293 [details]
Patch

[Chris Dumez]

Comment on attachment 204293 [details]
Patch

Looks fine, r=me.

[Ryuan Choi]

Committed r151427: <http://trac.webkit.org/changeset/151427>