Bug 117435

Summary: Add support for WaveShaperNode.oversample
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, gyuyoung.kim, jer.noble, kbr, rakuco, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Rogers
Reported 2013-06-10 16:06:06 PDT
Add support for WaveShaperNode.oversample
Attachments
Patch (52.26 KB, patch)
2013-06-10 16:11 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (52.52 KB, patch)
2013-06-10 17:35 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (52.25 KB, patch)
2013-07-15 13:35 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2013-06-10 16:11:48 PDT
Created attachment 204222 [details] Patch
Chris Rogers
Comment 2 2013-06-10 17:35:58 PDT
Created attachment 204233 [details] Patch
Build Bot
Comment 3 2013-06-10 17:51:53 PDT
Comment on attachment 204233 [details] Patch Attachment 204233 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/793217
Build Bot
Comment 4 2013-06-10 20:26:47 PDT
Comment on attachment 204233 [details] Patch Attachment 204233 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/659606
Chris Rogers
Comment 5 2013-07-15 13:35:32 PDT
Created attachment 206681 [details] Patch
Kenneth Russell
Comment 6 2013-07-15 15:02:08 PDT
Comment on attachment 206681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206681&action=review r=me based on previous review and comparing to the earlier CL. > Source/WebCore/platform/audio/DownSampler.cpp:44 > + , m_inputBuffer(inputBlockSize * 2) I noticed the initialization order differs from Blink's (and Blink's is likely wrong, not having the same warnings enabled as errors as WebKit). Do you plan to fix Blink's code? > Source/WebCore/platform/audio/UpSampler.cpp:44 > + , m_inputBuffer(inputBlockSize * 2) Same comment about initialization order.
WebKit Commit Bot
Comment 7 2013-07-15 21:54:46 PDT
Comment on attachment 206681 [details] Patch Clearing flags on attachment: 206681 Committed r152702: <http://trac.webkit.org/changeset/152702>
WebKit Commit Bot
Comment 8 2013-07-15 21:54:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.