Bug 117391

Summary: [EFL] Window resize should close the popupmenu
Product: WebKit Reporter: Santosh Mahto <santosh.ma>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: cdumez, commit-queue, gtk-ews, gyuyoung.kim, lucas.de.marchi, xan.lopez
Priority: P2    
Version: 525.x (Safari 3.2)   
Hardware: Other   
OS: Linux   
Description Flags
Test page showing popup menu list
Patch for landing
Patch for landing none

Description Santosh Mahto 2013-06-09 23:56:17 PDT
Created attachment 204137 [details]
Test page showing popup menu list

In EFL when window is resized the popup menu(<select>) should gets hidden.otherwise
on resizing the popupmenu is incorrectly placed (possibly on different selection box)

We hide the context menu on window resize , in the same way we should hide the popup menu 
This behaviour is observed in windows chrome/firefox
Comment 1 Santosh Mahto 2013-06-09 23:58:01 PDT
Created attachment 204138 [details]
Comment 2 Chris Dumez 2013-06-10 00:12:19 PDT
Comment on attachment 204138 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=204138&action=review

> Tools/MiniBrowser/efl/main.c:281
> +        evas_object_del(window->popup.elm_menu);

Please use elm_menu_close() to be consistent with on_popup_menu_hide().
Comment 3 Santosh Mahto 2013-06-10 01:50:14 PDT
Created attachment 204141 [details]
Comment 4 Chris Dumez 2013-06-10 02:27:58 PDT
Comment on attachment 204141 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=204141&action=review

Looks OK, r=me with nit.

> Tools/ChangeLog:7
> +

Please add a changelog before landing.
Comment 5 kov's GTK+ EWS bot 2013-06-10 05:53:37 PDT
Comment on attachment 204141 [details]

Attachment 204141 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/725615
Comment 6 Santosh Mahto 2013-06-11 18:35:03 PDT
Created attachment 204378 [details]
Patch for landing
Comment 7 Gyuyoung Kim 2013-06-11 19:09:49 PDT
Comment on attachment 204378 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=204378&action=review

> Tools/ChangeLog:6
> +        Reviewed by Christophe Dumez.

Need to add a new line.
Comment 8 Santosh Mahto 2013-06-11 19:14:58 PDT
Created attachment 204381 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2013-06-11 19:54:43 PDT
Comment on attachment 204381 [details]
Patch for landing

Clearing flags on attachment: 204381

Committed r151483: <http://trac.webkit.org/changeset/151483>
Comment 10 WebKit Commit Bot 2013-06-11 19:54:46 PDT
All reviewed patches have been landed.  Closing bug.