| Summary: | [CoordinatedGraphics] Typo in argument decoder for CoordinatedGraphicsState | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ralph T <ralpht+bugs> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, cmarcelo, commit-queue, dongseong.hwang, jaepark, luiz, noam, ralpht+bugs, rniwa, zeno | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 204128 [details]
Patch
(In reply to comment #0) > I noticed that CoordinatedGraphicsArgumentCoders.cpp:1187 is wrong for CSS shaders, it currently reads: > > if (!decoder.decode(state.updateAtlasesToRemove)) > return false; > > But it should say: > > if (!decoder.decode(state.customFiltersToRemove)) > return false; Thanks for reporting! I quickly made a patch to fix this. I hope you don't mind. Comment on attachment 204128 [details] Patch Attachment 204128 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/803133 New failing tests: http/tests/security/cross-origin-plugin-private-browsing-toggled.html Created attachment 204131 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
(In reply to comment #2) > Thanks for reporting! > I quickly made a patch to fix this. I hope you don't mind. Not at all, thanks for being proactive :). Comment on attachment 204128 [details]
Patch
EWS responds to a flaky test, this code does not get compiled on Mac.
Comment on attachment 204128 [details] Patch Clearing flags on attachment: 204128 Committed r151364: <http://trac.webkit.org/changeset/151364> All reviewed patches have been landed. Closing bug. |
I noticed that CoordinatedGraphicsArgumentCoders.cpp:1187 is wrong for CSS shaders, it currently reads: if (!decoder.decode(state.updateAtlasesToRemove)) return false; But it should say: if (!decoder.decode(state.customFiltersToRemove)) return false;