Bug 11738

Summary: Make clicking links work again on Windows
Product: WebKit Reporter: Don Gibson <dgibson77>
Component: WebCore Misc.Assignee: Don Gibson <dgibson77>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch v1 ap: review+

Don Gibson
Reported 2006-12-01 16:02:27 PST
In fixing the Windows build a few weeks ago, I simply stubbed out some loader functions rather than porting over the original versions from FrameWin. Fixing this will mean link clicks work again. Patch coming shortly.
Attachments
patch v1 (23.67 KB, patch)
2006-12-01 16:11 PST, Don Gibson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Gibson
Comment 1 2006-12-01 16:11:07 PST
Created attachment 11710 [details] patch v1 Re-implements a few bits that used to be in FrameWin, adds a few EventHandler forwarding functions (may not be strictly necessary), and patches mouse message handling to ignore unnecessary move events, so link clicks actually get through instead of being invalidated in most cases.
Don Gibson
Comment 2 2006-12-01 16:13:40 PST
Oh yeah, I forgot that the patch also updates a lot of the formerly-AbstractShared Windows classes to no longer inherit from Shared<>. I don't know how this is managing to compile on the trunk and how it compiled for me before, but as soon as I started touching my checkout today it (rightfully) broke.
Alexey Proskuryakov
Comment 3 2006-12-04 11:45:03 PST
Comment on attachment 11710 [details] patch v1 r=me
Alexey Proskuryakov
Comment 4 2006-12-04 11:49:23 PST
Committed revision 18000.
Note You need to log in before you can comment on or make changes to this bug.