Bug 11738 - Make clicking links work again on Windows
Summary: Make clicking links work again on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Don Gibson
Depends on:
Reported: 2006-12-01 16:02 PST by Don Gibson
Modified: 2006-12-04 11:49 PST (History)
0 users

See Also:

patch v1 (23.67 KB, patch)
2006-12-01 16:11 PST, Don Gibson
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Gibson 2006-12-01 16:02:27 PST
In fixing the Windows build a few weeks ago, I simply stubbed out some loader functions rather than porting over the original versions from FrameWin.  Fixing this will mean link clicks work again.

Patch coming shortly.
Comment 1 Don Gibson 2006-12-01 16:11:07 PST
Created attachment 11710 [details]
patch v1

Re-implements a few bits that used to be in FrameWin, adds a few EventHandler forwarding functions (may not be strictly necessary), and patches mouse message handling to ignore unnecessary move events, so link clicks actually get through instead of being invalidated in most cases.
Comment 2 Don Gibson 2006-12-01 16:13:40 PST
Oh yeah, I forgot that the patch also updates a lot of the formerly-AbstractShared Windows classes to no longer inherit from Shared<>.  I don't know how this is managing to compile on the trunk and how it compiled for me before, but as soon as I started touching my checkout today it (rightfully) broke.
Comment 3 Alexey Proskuryakov 2006-12-04 11:45:03 PST
Comment on attachment 11710 [details]
patch v1

Comment 4 Alexey Proskuryakov 2006-12-04 11:49:23 PST
Committed revision 18000.