| Summary: | fourthTier: Recursive deadlock in DFG::ByteCodeParser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2013-06-08 18:17:33 PDT
Created attachment 204105 [details]
the patch
Comment on attachment 204105 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review r=me > Source/WTF/ChangeLog:8 > + I've often wanted to leave a lock early. Now I have that power! Yay! Comment on attachment 204105 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > Source/WTF/wtf/Locker.h:39 > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > + Locker(T* lockable) : m_lockable(lockable) { lock(); } I think these ought to say explicit. (In reply to comment #3) > (From update of attachment 204105 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > > > Source/WTF/wtf/Locker.h:39 > > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > > + Locker(T* lockable) : m_lockable(lockable) { lock(); } > > I think these ought to say explicit. Yes. Will change. Landed in http://trac.webkit.org/changeset/151352 |