Bug 117376

Summary:

fourthTier: Recursive deadlock in DFG::ByteCodeParser

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Filip Pizlo

Reported 2013-06-08 18:17:33 PDT

Attachments
the patch (3.26 KB, patch) 2013-06-08 18:19 PDT, Filip Pizlo	mhahnenberg: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-06-08 18:19:05 PDT

Mark Hahnenberg

Comment 2 2013-06-08 18:37:15 PDT

Comment on attachment 204105 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review r=me > Source/WTF/ChangeLog:8 > + I've often wanted to leave a lock early. Now I have that power! Yay!

Darin Adler

Comment 3 2013-06-08 18:46:22 PDT

Comment on attachment 204105 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > Source/WTF/wtf/Locker.h:39 > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > + Locker(T* lockable) : m_lockable(lockable) { lock(); } I think these ought to say explicit.

Filip Pizlo

Comment 4 2013-06-08 18:57:07 PDT

(In reply to comment #3) > (From update of attachment 204105 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > > > Source/WTF/wtf/Locker.h:39 > > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > > + Locker(T* lockable) : m_lockable(lockable) { lock(); } > > I think these ought to say explicit. Yes. Will change.

Filip Pizlo

Comment 5 2013-06-08 22:41:35 PDT

Note You need to log in before you can comment on or make changes to this bug.