Bug 117366

Summary: isContravenedByStructure is backwards
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch fpizlo: review+

Description Mark Hahnenberg 2013-06-07 17:02:14 PDT
We should be checking if arrayModeForStructure(structure) is a subset of arrayModesThatPassFiltering(), not the other way around.
Comment 1 Mark Hahnenberg 2013-06-07 17:03:22 PDT
Created attachment 204075 [details]
Comment 2 Filip Pizlo 2013-06-07 17:10:31 PDT
Comment on attachment 204075 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=204075&action=review

> Source/JavaScriptCore/dfg/DFGArrayMode.h:366
>      bool isContravenedByStructure(Structure* structure)

Can we make it clearer that the thing that was proven was the structure?

What about having a method called: structureWouldPassArrayModeFiltering(Structure*)

RS=me to make a change like that
Comment 3 Mark Hahnenberg 2013-06-11 13:53:42 PDT
Committed r151468: <http://trac.webkit.org/changeset/151468>