Bug 117343

Summary: REGRESSION: r149001 made proximity test fail.
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: Tools / TestsAssignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kihong Kwon
Reported 2013-06-07 05:45:13 PDT
Update window-property.html test cases for Device Proximity Event. The global constructors are no longer enumerable after r149001.
Attachments
Patch (2.32 KB, patch)
2013-06-07 05:49 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (2.81 KB, patch)
2013-06-07 06:11 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (2.59 KB, patch)
2013-06-07 06:40 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2013-06-07 05:49:08 PDT
Created attachment 204032 [details] Patch
Chris Dumez
Comment 2 2013-06-07 05:54:36 PDT
Comment on attachment 204032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204032&action=review The change is correct. Why doesn't it unskip the test for any port? > LayoutTests/proximity/window-property.html:-20 > -shouldBeTrue("hasDeviceProximityEventProperty()"); hasDeviceProximityEventProperty function above can be removed as well.
Kihong Kwon
Comment 3 2013-06-07 06:01:05 PDT
Device Proximity Event is not enabled yet on the all port. I will enable this on the efl soon. And I will remove "shouldBeTrue("hasDeviceProximityEventProperty()");" also.
Kihong Kwon
Comment 4 2013-06-07 06:11:27 PDT
Created attachment 204035 [details] Patch
Chris Dumez
Comment 5 2013-06-07 06:31:40 PDT
Comment on attachment 204035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204035&action=review Sorry this is not what I meant. > LayoutTests/proximity/window-property.html:20 > +shouldBeFalse("window.propertyIsEnumerable('DeviceProximityEvent')"); This change is OK. However, the hasDeviceProximityEventProperty() function 10 lines above should be removed as well and it is likely not used anymore. > LayoutTests/proximity/window-property.html:-34 > -shouldBeTrue("hasOnDeviceProximityProperty()"); This is unrelated and should stay.
Kihong Kwon
Comment 6 2013-06-07 06:40:30 PDT
Created attachment 204038 [details] Patch
Chris Dumez
Comment 7 2013-06-07 06:41:58 PDT
Comment on attachment 204038 [details] Patch Looks good, thanks. r=me.
WebKit Commit Bot
Comment 8 2013-06-07 07:40:54 PDT
Comment on attachment 204038 [details] Patch Clearing flags on attachment: 204038 Committed r151317: <http://trac.webkit.org/changeset/151317>
WebKit Commit Bot
Comment 9 2013-06-07 07:40:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.