Bug 117335

Summary: [EFL][GTK] TextCheckerEnchant uses deprecated enchant_dict_add_to_personal
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, mario, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Grzegorz Czajkowski
Reported 2013-06-07 02:07:39 PDT
enchant_dict_add_to_personal has been deprecated at r22321 in Enchant repository. We should call enchant_dict_add instead of enchant_dict_add_to_personal.
Attachments
proposed patch (1.67 KB, patch)
2013-06-07 02:11 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2013-06-07 02:11:28 PDT
Created attachment 204018 [details] proposed patch
Mario Sanchez Prada
Comment 2 2013-06-07 03:26:38 PDT
Comment on attachment 204018 [details] proposed patch Indeed it seems this function has been deprecated already a long time ago in favor of enchant_dict_add(). Thus, no objections at all Thanks for the patch
Chris Dumez
Comment 3 2013-06-07 06:11:48 PDT
Comment on attachment 204018 [details] proposed patch Thanks for informal review Mario. r=me.
WebKit Commit Bot
Comment 4 2013-06-07 06:36:27 PDT
Comment on attachment 204018 [details] proposed patch Clearing flags on attachment: 204018 Committed r151316: <http://trac.webkit.org/changeset/151316>
WebKit Commit Bot
Comment 5 2013-06-07 06:36:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.