Bug 117332

Summary: [GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL
Product: WebKit Reporter: Diego Pino <dpino>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: cdumez, commit-queue, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Diego Pino 2013-06-06 23:37:10 PDT
According to the 'Document Object Model' CSS spec:


Parameter 'pseudoElement' from function 'getComputedStyle' could be null. The GObject binding generator generates code that always check this parameter cannot be null.
Comment 1 Diego Pino 2013-06-06 23:45:58 PDT
Created attachment 204004 [details]
Comment 2 Xan Lopez 2013-06-12 00:46:51 PDT
Comment on attachment 204004 [details]

Looks good in general. It's a bit sad to duplicate some of the setup code but the existing one seems pretty specific to the test that uses it.
Comment 3 WebKit Commit Bot 2013-06-12 01:09:55 PDT
Comment on attachment 204004 [details]

Clearing flags on attachment: 204004

Committed r151489: <http://trac.webkit.org/changeset/151489>
Comment 4 WebKit Commit Bot 2013-06-12 01:09:58 PDT
All reviewed patches have been landed.  Closing bug.