Bug 117332

Summary: [GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL
Product: WebKit Reporter: Diego Pino <dpino>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Diego Pino
Reported 2013-06-06 23:37:10 PDT
According to the 'Document Object Model' CSS spec: http://www.w3.org/TR/DOM-Level-2-Style/css.html Parameter 'pseudoElement' from function 'getComputedStyle' could be null. The GObject binding generator generates code that always check this parameter cannot be null.
Attachments
Patch (6.21 KB, patch)
2013-06-06 23:45 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2013-06-06 23:45:58 PDT
Created attachment 204004 [details] Patch
Xan Lopez
Comment 2 2013-06-12 00:46:51 PDT
Comment on attachment 204004 [details] Patch Looks good in general. It's a bit sad to duplicate some of the setup code but the existing one seems pretty specific to the test that uses it.
WebKit Commit Bot
Comment 3 2013-06-12 01:09:55 PDT
Comment on attachment 204004 [details] Patch Clearing flags on attachment: 204004 Committed r151489: <http://trac.webkit.org/changeset/151489>
WebKit Commit Bot
Comment 4 2013-06-12 01:09:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.