Bug 117298

Summary: [EFL][WK2] Implement customContextMenuItemSelected
Product: WebKit Reporter: Michal Pakula vel Rutka <mpakulavelrutka>
Component: WebKit EFLAssignee: Michal Pakula vel Rutka <mpakulavelrutka>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eflews.bot, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 116601    
Attachments:
Description Flags
proposed patch
eflews.bot: commit-queue-
fixed patch none

Michal Pakula vel Rutka
Reported 2013-06-06 07:46:10 PDT
Currently, when custom context menu item is selected, application is not informed.
Attachments
proposed patch (5.47 KB, patch)
2013-06-07 01:53 PDT, Michal Pakula vel Rutka 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
fixed patch (5.44 KB, patch)
2013-06-07 02:08 PDT, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michal Pakula vel Rutka
Comment 1 2013-06-07 01:53:37 PDT
Created attachment 204015 [details] proposed patch
EFL EWS Bot
Comment 2 2013-06-07 01:58:11 PDT
Comment on attachment 204015 [details] proposed patch Attachment 204015 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/695795
Michal Pakula vel Rutka
Comment 3 2013-06-07 02:08:45 PDT
Created attachment 204017 [details] fixed patch
Chris Dumez
Comment 4 2013-06-07 03:31:47 PDT
Comment on attachment 204017 [details] fixed patch View in context: https://bugs.webkit.org/attachment.cgi?id=204017&action=review > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:838 > + OwnPtr<EwkContextMenuItem> item = EwkContextMenuItem::create(contextMenuItem, 0); Wouldn't it be nicer to provide the existing EwkContextMenuItem object instead of creating a new one? I guess we can retrieve the existing one from m_contextMenu somehow.
Chris Dumez
Comment 5 2013-06-07 03:51:41 PDT
Comment on attachment 204017 [details] fixed patch Ok, r=me after discussing this offline. Figuring out the ewk item from the WK one is not trivial.
WebKit Commit Bot
Comment 6 2013-06-07 04:20:17 PDT
Comment on attachment 204017 [details] fixed patch Clearing flags on attachment: 204017 Committed r151313: <http://trac.webkit.org/changeset/151313>
WebKit Commit Bot
Comment 7 2013-06-07 04:20:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.