Bug 117271

Summary: [BlackBerry] Make image clickable when it has anchor as parent node.
Product: WebKit Reporter: Tiancheng Jiang <tijiang>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tiancheng Jiang 2013-06-05 12:37:30 PDT 
Make the image click-able when it has anchor as parent. Although to check all the ancestors would be safe but it is too expensive. We will consider that later.
Comment 1 Tiancheng Jiang 2013-06-05 13:08:01 PDT 
Created attachment 203876 [details]
Patch
Comment 2 Rob Buis 2013-06-05 13:13:42 PDT 
Comment on attachment 203876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203876&action=review

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:96
> +        || (element->hasTagName(HTMLNames::imgTag) && element->parentNode()->hasTagName(HTMLNames::aTag)))

Is it possible for parentNode to be null here?
Comment 3 Tiancheng Jiang 2013-06-05 13:33:30 PDT 
Created attachment 203878 [details]
Patch
Comment 4 Rob Buis 2013-06-05 13:58:35 PDT 
Comment on attachment 203878 [details]
Patch

LGTM.
Comment 5 WebKit Commit Bot 2013-06-05 14:40:17 PDT 
Comment on attachment 203878 [details]
Patch

Clearing flags on attachment: 203878

Committed r151240: <http://trac.webkit.org/changeset/151240>
Comment 6 WebKit Commit Bot 2013-06-05 14:40:19 PDT 
All reviewed patches have been landed.  Closing bug.