Bug 117270 – [CSS Regions] Layers inside the RenderFlowThread should be collected by the layer of RenderView

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Alexandru Chiculita]

In order to enable compositing we need to enable the collection of RenderLayers from the RenderFlowThread.

Right now the RenderLayer::collectLayers would skip any RenderFlowThreads, leaving the RenderFlowThread outside of the layers tree. Any other traversals would skip the RenderFlowThreads leaving the layers inside in inconsistent states.

This patch would change the RenderLayer::collectLayers and update other functions to ignore RenderFlowThreads when calculating bounds of, paint or hit-test the RenderView.

[Alexandru Chiculita]

Created attachment 203888 [details]
Patch V1

[Dave Hyatt]

Comment on attachment 203888 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=203888&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        and hit-tested through their regions. The easies way to prevent the RenderView 

"easiest"

[Alexandru Chiculita]

Created attachment 204051 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 204051 [details]
Patch for landing

Rejecting attachment 204051 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 204051, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Dave Hyatt found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/788004

[Alexandru Chiculita]

Created attachment 204069 [details]
Patch for landing

Fixed reviewer's name :)

[WebKit Commit Bot]

Comment on attachment 204069 [details]
Patch for landing

Clearing flags on attachment: 204069

Committed r151339: <http://trac.webkit.org/changeset/151339>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

This caused 4 new assertions in layout tests:
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r151339%20(10463)/results.html

[Csaba Osztrogonác]

See https://bugs.webkit.org/show_bug.cgi?id=117404 for the details.

[Alexandru Chiculita]

(In reply to comment #9)
> See https://bugs.webkit.org/show_bug.cgi?id=117404 for the details.

The assert was fixed in https://bugs.webkit.org/show_bug.cgi?id=117395 .