Summary: | Remove remaining custom getters for WorkerContext constructor attributes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, ggaren, haraken, laszlo.gombos, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2013-06-05 04:31:58 PDT
Created attachment 203802 [details]
WIP patch
Created attachment 203803 [details]
JSWebContext.cpp diff
Created attachment 203808 [details]
Patch
Comment on attachment 203808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203808&action=review Great improvement. > Source/WebCore/dom/MessageChannel.idl:29 > + Conditional=CHANNEL_MESSAGING, I wonder why MessageChannel code has been working without this conditional. Comment on attachment 203808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203808&action=review >> Source/WebCore/dom/MessageChannel.idl:29 >> + Conditional=CHANNEL_MESSAGING, > > I wonder why MessageChannel code has been working without this conditional. Looks like everyone is enabling CHANNEL_MESSAGING: Tools/Scripts/webkitperl/FeatureList.pm: define => "ENABLE_CHANNEL_MESSAGING", default => 1, value => \$channelMessagingSupport }, Comment on attachment 203808 [details]
Patch
ok, thanks for the clarification.
Comment on attachment 203808 [details] Patch Clearing flags on attachment: 203808 Committed r151223: <http://trac.webkit.org/changeset/151223> All reviewed patches have been landed. Closing bug. |