Bug 117247

Summary: Remove remaining custom getters for WorkerContext constructor attributes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, ggaren, haraken, laszlo.gombos, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
JSWebContext.cpp diff
none
Patch none

Chris Dumez
Reported 2013-06-05 04:31:58 PDT
The following constructor attributes on WorkerContext interface have custom getters but their custom code doesn't seem to do anything special: [Conditional=CHANNEL_MESSAGING, CustomGetter] attribute MessageChannelConstructor MessageChannel; [CustomGetter] attribute EventSourceConstructor EventSource; [CustomGetter] attribute XMLHttpRequestConstructor XMLHttpRequest; [CustomGetter] attribute WebSocketConstructor WebSocket; We can probably remove the custom code and have them automatically generated.
Attachments
WIP patch (10.35 KB, patch)
2013-06-05 04:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
JSWebContext.cpp diff (1.90 KB, patch)
2013-06-05 04:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.73 KB, patch)
2013-06-05 05:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-06-05 04:36:29 PDT
Created attachment 203802 [details] WIP patch
Chris Dumez
Comment 2 2013-06-05 04:37:43 PDT
Created attachment 203803 [details] JSWebContext.cpp diff
Chris Dumez
Comment 3 2013-06-05 05:15:17 PDT
Created attachment 203808 [details] Patch
Kentaro Hara
Comment 4 2013-06-05 05:19:14 PDT
Comment on attachment 203808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203808&action=review Great improvement. > Source/WebCore/dom/MessageChannel.idl:29 > + Conditional=CHANNEL_MESSAGING, I wonder why MessageChannel code has been working without this conditional.
Chris Dumez
Comment 5 2013-06-05 05:26:52 PDT
Comment on attachment 203808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203808&action=review >> Source/WebCore/dom/MessageChannel.idl:29 >> + Conditional=CHANNEL_MESSAGING, > > I wonder why MessageChannel code has been working without this conditional. Looks like everyone is enabling CHANNEL_MESSAGING: Tools/Scripts/webkitperl/FeatureList.pm: define => "ENABLE_CHANNEL_MESSAGING", default => 1, value => \$channelMessagingSupport },
Kentaro Hara
Comment 6 2013-06-05 06:54:48 PDT
Comment on attachment 203808 [details] Patch ok, thanks for the clarification.
WebKit Commit Bot
Comment 7 2013-06-05 07:16:46 PDT
Comment on attachment 203808 [details] Patch Clearing flags on attachment: 203808 Committed r151223: <http://trac.webkit.org/changeset/151223>
WebKit Commit Bot
Comment 8 2013-06-05 07:16:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.