| Summary: | Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||
| Component: | Tools / Tests | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dbates, gustavo, pnormand, roger_fong | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Raphael Kubo da Costa (:rakuco)
2013-06-05 04:20:29 PDT
Created attachment 203799 [details]
Patch
Comment on attachment 203799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review > Tools/Scripts/webkitdirs.pm:188 > + $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir; I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR. Created attachment 203810 [details]
Patch for landing
(In reply to comment #2) > (From update of attachment 203799 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review > > > Tools/Scripts/webkitdirs.pm:188 > > + $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir; > > I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR. Done: https://bugs.webkit.org/show_bug.cgi?id=117249 Landed in <https://trac.webkit.org/r151216>. |