Bug 117244

Summary: Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates, gns, pnormand, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Raphael Kubo da Costa (:rakuco) 2013-06-05 04:20:29 PDT
Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
Comment 1 Raphael Kubo da Costa (:rakuco) 2013-06-05 04:22:26 PDT
Created attachment 203799 [details]
Patch
Comment 2 Daniel Bates 2013-06-05 05:21:44 PDT
Comment on attachment 203799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review

> Tools/Scripts/webkitdirs.pm:188
> +    $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir;

I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR.
Comment 3 Raphael Kubo da Costa (:rakuco) 2013-06-05 05:32:07 PDT
Created attachment 203810 [details]
Patch for landing
Comment 4 Raphael Kubo da Costa (:rakuco) 2013-06-05 05:32:20 PDT
(In reply to comment #2)
> (From update of attachment 203799 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review
> 
> > Tools/Scripts/webkitdirs.pm:188
> > +    $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir;
> 
> I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR.

Done: https://bugs.webkit.org/show_bug.cgi?id=117249
Comment 5 Raphael Kubo da Costa (:rakuco) 2013-06-05 05:35:54 PDT
Landed in <https://trac.webkit.org/r151216>.