Bug 117232 – [Threaded Compositor] Apply scroll-offset and scale in Widget window coordinate.

• Component: WebKit2
• Status: UNCONFIRMED

[Gwang Yoon Hwang]

We need to apply scrolling and scaling to mouse event when we are in
    delegatedScrolling. To do that, scroll-offset should be cached in
    WebPageProxy, because mouse event should be transformed at its creation
    time.
    
    No new tests, covered by existing tests.

[Gwang Yoon Hwang]

Created attachment 206080 [details]
Patch

[Michael Catanzaro]

Comment on attachment 206080 [details]
Patch

Is this patch still needed? I'm going to remove the r? since I presume it's obsolete; please reset it if it's still needed.

[Michael Catanzaro]

Comment on attachment 206080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206080&action=review

Nevermind, you can just close the bug if it's obsolete.

> Source/WebCore/platform/Widget.cpp:145
> +IntRect Widget::convertFromRootToContainingWindow(const Widget* widget, const IntRect& rect)

These functions ought to take a const Widget& rather than a const Widget*, since it will crash if widget is ever null. (That should be changed in a follow-up patch.)

> Source/WebCore/platform/Widget.cpp:148
> +    const ScrollView* scrollView = widget->root();

scrollView can never be null here?

[Carlos Garcia Campos]

Comment on attachment 206080 [details]
Patch

Clearing flags, we need an explanation of what is broken and what this fixes. Widget doesn't looke like the right place for this to me, but I don't really understand the change.