Bug 117212

Summary: [Windows] Revise Windows code in NRWT to properly distinguish between "win32" and "cygwin" behavior
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dpranke, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 117098    
Bug Blocks:    
Attachments:
Description Flags
Patch dpranke: review+

Brent Fulgham
Reported 2013-06-04 15:10:34 PDT
Dirk Pranke pointed out that changes I made under Bug 117098 improperly treated the "win32" and "cygwin" variants of Windows builds as the same thing. Unfortunately, Windows does not provide a 'ps' tool, and so cannot be handled the same way as our Cygwin infrastructure. This patch makes the following corrections: 1. It returns to the original "win32" behavior of returning an empty list when attempting to find running PIDs. 2. Revise crashlog object to accept a "results directory" argument, rather than requiring the user to pass a port object when attempting to retrieve crash logs.
Attachments
Patch (7.03 KB, patch)
2013-06-04 15:14 PDT, Brent Fulgham 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-06-04 15:14:42 PDT
Created attachment 203730 [details] Patch
Dirk Pranke
Comment 2 2013-06-04 15:30:43 PDT
Comment on attachment 203730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203730&action=review > Tools/Scripts/webkitpy/common/system/crashlogs.py:39 > + self._results_directory = results_directory I was suggesting you make one change or the other, and you came up with a weird hybrid :). I would just pass results_directory into find_newest_log(), but this is okay, too.
Brent Fulgham
Comment 3 2013-06-04 16:48:03 PDT
Committed r151191: <http://trac.webkit.org/changeset/151191>
Note You need to log in before you can comment on or make changes to this bug.