Summary: | Avoid multiple copies of inline script & style strings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arunprasad Rajkumar <arurajku> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, ararunprasad, bfulgham, commit-queue, esprehn+autocc, kling, koivisto, rniwa | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Arunprasad Rajkumar
2013-06-04 08:56:52 PDT
Sounds like a really valuable optimization. Created attachment 203874 [details]
Patch
Seems like a good change. ap, any reason you did not r+ this? Comment on attachment 203874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203874&action=review > Source/WebCore/html/parser/HTMLConstructionSite.cpp:500 > + unsigned lengthLimit = shouldUseLengthLimit(task.parent.get()) ? Text::defaultLengthLimit : std::numeric_limits<unsigned>::max(); Too bad we need to compute this limit ahead of time. Sure would be nice to only do the work when we actually get close enough to hitting a limit. Comment on attachment 203874 [details] Patch Clearing flags on attachment: 203874 Committed r151236: <http://trac.webkit.org/changeset/151236> All reviewed patches have been landed. Closing bug. |