| Summary: | [GTK] Forwarding headers not generated for incremental build | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wojciech Bielawski <w.bielawski> | ||||||||
| Component: | Tools / Tests | Assignee: | Wojciech Bielawski <w.bielawski> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, gustavo, mrobinson, zan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 98410 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wojciech Bielawski
2013-06-04 07:43:42 PDT
Created attachment 203696 [details]
Generate forwarding headers if needed even for incremental build
Thanks for Zan Dobersek. Created attachment 203699 [details]
Now with changelog
Comment on attachment 203699 [details] Now with changelog View in context: https://bugs.webkit.org/attachment.cgi?id=203699&action=review Patch looks good to me, could you please update the changelog entry to match the bug? We have scripts that parse the changelog entries, so it's important to make sure they are generated correctly. Use the prepare-ChangeLog script to make sure. > Tools/ChangeLog:3 > + [GTK] Generate forwarding headers if needed even for incremental build. This doesn't match the bug title, you should use the Tools/Scripts/prepare-ChangeLog to generate the changelog entry. > Tools/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=117198. And this doesn't finish with a period Created attachment 203786 [details]
changelog generated with script (and --bug argument)
Now prepare-ChangeLog had generated Title without period on the end. Is it correct?
Comment on attachment 203786 [details] changelog generated with script (and --bug argument) Clearing flags on attachment: 203786 Committed r151215: <http://trac.webkit.org/changeset/151215> All reviewed patches have been landed. Closing bug. |