Bug 117195

Summary: [Qt] Font::shouldUseSmoothing() has fake dependency on Qt 5.1
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Layout and RenderingAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jturcotte, kadam, noam, ossy, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 117699, 117702    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2013-06-04 06:46:02 PDT
We should get rid of this fake dependency as the changes it causes could mask real regressions in Qt 5.1.
Attachments
Patch (1.98 KB, patch)
2013-06-04 07:05 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-06-04 07:05:16 PDT
Created attachment 203693 [details] Patch
Zoltan Arvai
Comment 2 2013-06-04 15:28:45 PDT
It seems about 5400 png result are affected. Landing rebaselines will take a while. Is there a size limit for a commit? :)
Csaba Osztrogonác
Comment 3 2013-06-05 00:09:00 PDT
(In reply to comment #2) > It seems about 5400 png result are affected. Landing rebaselines will take a while. Is there a size limit for a commit? :) There isn't size limit. But I suggest rebasing in ~500 sized batches to avoid LayoutTests/ChangeLog conflict during half an hour long commit. And commit in an IDLE time.
WebKit Commit Bot
Comment 4 2013-06-05 02:29:01 PDT
Comment on attachment 203693 [details] Patch Clearing flags on attachment: 203693 Committed r151205: <http://trac.webkit.org/changeset/151205>
WebKit Commit Bot
Comment 5 2013-06-05 02:29:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.