Bug 117188

Summary:

[BLACKBERRY]RSS not working with browser

Product:

WebKit

Reporter:

minggang wang <mingwang>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rwlbuis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
path	mingwang: commit-queue-
new patch	mingwang: review-
correct patch	rwlbuis: review+, commit-queue: commit-queue-

minggang wang

Reported 2013-06-04 03:43:02 PDT

Internal PR 341330 Internal reviewed by Joe Mason Browser won't recognize the RSS content, when the "Content-Type" in http header is wrong (not "text/xml").

Attachments
path (8.58 KB, patch) 2013-06-04 03:56 PDT, minggang wang	mingwang: commit-queue-	Details Formatted Diff Diff
new patch (14.35 KB, patch) 2013-06-04 04:09 PDT, minggang wang	mingwang: review-	Details Formatted Diff Diff
correct patch (8.90 KB, patch) 2013-06-04 04:17 PDT, minggang wang	rwlbuis: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

minggang wang

Comment 1 2013-06-04 03:56:21 PDT

Created attachment 203675 [details] path

minggang wang

Comment 2 2013-06-04 04:09:52 PDT

Created attachment 203678 [details] new patch

minggang wang

Comment 3 2013-06-04 04:17:58 PDT

Created attachment 203679 [details] correct patch

minggang wang

Comment 4 2013-06-05 01:22:12 PDT

Comment on attachment 203678 [details] new patch wrong patch

minggang wang

Comment 5 2013-06-05 01:35:28 PDT

Comment on attachment 203675 [details] path wrong patch

minggang wang

Comment 6 2013-06-05 01:36:35 PDT

Comment on attachment 203679 [details] correct patch pls review this patch

Rob Buis

Comment 7 2013-06-13 10:11:39 PDT

Comment on attachment 203679 [details] correct patch Looks good.

WebKit Commit Bot

Comment 8 2013-06-13 10:12:49 PDT

Comment on attachment 203679 [details] correct patch Rejecting attachment 203679 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 203679, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/896009

Rob Buis

Comment 9 2013-07-30 07:40:23 PDT

(In reply to comment #6) > (From update of attachment 203679 [details]) > pls review this patch Sorry for forgetting about this one. Mingwang if you still want this in you have to fix the Changelog. If it is not needed you can close the bug.

Note You need to log in before you can comment on or make changes to this bug.