[CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code

• Component: CSS
• Status: RESOLVED FIXED

[Bear Travis]

With CSS Exclusions & Shapes splitting into two separate features, some code cleanup is required.
http://dev.w3.org/csswg/css-exclusions/
http://dev.w3.org/csswg/css-shapes/

This work will clean up the implementation side.
A subsequent patch will clean up the test side.

[Bear Travis]

Created attachment 203633 [details]
Initial Patch

[Bear Travis]

Created attachment 203894 [details]
Updated patch

[Early Warning System Bot]

Comment on attachment 203894 [details]
Updated patch

Attachment 203894 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/756256

[Early Warning System Bot]

Comment on attachment 203894 [details]
Updated patch

Attachment 203894 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/786051

[EFL EWS Bot]

Comment on attachment 203894 [details]
Updated patch

Attachment 203894 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/709903

[EFL EWS Bot]

Comment on attachment 203894 [details]
Updated patch

Attachment 203894 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/786052

[kov's GTK+ EWS bot]

Comment on attachment 203894 [details]
Updated patch

Attachment 203894 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/758687

[Bear Travis]

Created attachment 203953 [details]
Adding directory

[Early Warning System Bot]

Comment on attachment 203953 [details]
Adding directory

Attachment 203953 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/697563

[Early Warning System Bot]

Comment on attachment 203953 [details]
Adding directory

Attachment 203953 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/790018

[EFL EWS Bot]

Comment on attachment 203953 [details]
Adding directory

Attachment 203953 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/695650

[EFL EWS Bot]

Comment on attachment 203953 [details]
Adding directory

Attachment 203953 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/658714

[kov's GTK+ EWS bot]

Comment on attachment 203953 [details]
Adding directory

Attachment 203953 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/777228

[Bear Travis]

Created attachment 203967 [details]
Adding ShapeOutsideInfo.h to sources

[Early Warning System Bot]

Comment on attachment 203967 [details]
Adding ShapeOutsideInfo.h to sources

Attachment 203967 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/790055

[Early Warning System Bot]

Comment on attachment 203967 [details]
Adding ShapeOutsideInfo.h to sources

Attachment 203967 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/792010

[EFL EWS Bot]

Comment on attachment 203967 [details]
Adding ShapeOutsideInfo.h to sources

Attachment 203967 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/772478

[EFL EWS Bot]

Comment on attachment 203967 [details]
Adding ShapeOutsideInfo.h to sources

Attachment 203967 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/772479

[kov's GTK+ EWS bot]

Comment on attachment 203967 [details]
Adding ShapeOutsideInfo.h to sources

Attachment 203967 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/792025

[Bear Travis]

Created attachment 203976 [details]
Adding folders

[Bear Travis]

Created attachment 203977 [details]
Updating patch

[EFL EWS Bot]

Comment on attachment 203977 [details]
Updating patch

Attachment 203977 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/774331

[EFL EWS Bot]

Comment on attachment 203977 [details]
Updating patch

Attachment 203977 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/790080

[Bear Travis]

Created attachment 204056 [details]
cmakelists additions

[Hans Muller]

It would be helpful if there were a summary of the before/after classnames at the top of the ChangeLog.

[Zoltan Horvath]

Comment on attachment 204056 [details]
cmakelists additions

View in context: https://bugs.webkit.org/attachment.cgi?id=204056&action=review

It looks okay to me. 1 comment:

> Source/WebCore/rendering/RenderBlock.cpp:1447
> +    ShapeInsideInfo* shapeInsideInfo;

nit: you can leave this in the block below as it was before.

[Bear Travis]

Created attachment 204176 [details]
Updated, incorporating feedback

[Alexandru Chiculita]

Comment on attachment 204176 [details]
Updated, incorporating feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=204176&action=review

r=me

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:118
> +        ShapeInsideInfo* shapeInsideInfo = m_block->layoutShapeInsideInfo();
> +        if (shapeInsideInfo)

nit: The variable could live inside the condition statement. That's more like the WebKit style.

> Tools/ChangeLog:8
> +        Adding the rendering/shapes directory

nit: It looks like you forgot to finish the sentence in the WebKit project Changelogs. "Adding the webcore/rendering/shapes directory to the include list."

[Bear Travis]

Created attachment 204184 [details]
Incorporating feedback

[WebKit Commit Bot]

Comment on attachment 204184 [details]
Incorporating feedback

Clearing flags on attachment: 204184

Committed r151402: <http://trac.webkit.org/changeset/151402>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.