Bug 117157

Summary: [GTK][SOUP] Migrate SoupRequestManager to GTask
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, danw, gustavo, laszlo.gombos, xan.lopez
Priority: P2 Keywords: Gtk, Soup
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117149    
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2013-06-03 09:15:13 PDT
Migrate SoupRequestManager to GTask
Attachments
Patch (9.29 KB, patch)
2013-06-03 09:19 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-06-03 09:19:18 PDT
Created attachment 203602 [details] Patch
Chris Dumez
Comment 2 2013-06-05 01:14:49 PDT
Comment on attachment 203602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review > Source/WebKit2/ChangeLog:7 > + Could you please explain in the Changelog why we are migrating to GTask?
Gustavo Noronha (kov)
Comment 3 2013-06-17 20:18:19 PDT
Comment on attachment 203602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review I kept wondering if we could do away with the data struct like you did on the other patch, but I don't think there's a lot to gain here. >> Source/WebKit2/ChangeLog:7 >> + > > Could you please explain in the Changelog why we are migrating to GTask? ++
Carlos Garcia Campos
Comment 4 2013-06-19 00:32:25 PDT
(In reply to comment #3) > (From update of attachment 203602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review > > I kept wondering if we could do away with the data struct like you did on the other patch, but I don't think there's a lot to gain here. In this case the AsyncData struct is not only for the GTask async operation but for the whole custom uri scheme operation. Note that this data struct is not set as task data, but it contains the GTask that is released (see releaseTask) when it finishes. > >> Source/WebKit2/ChangeLog:7 > >> + > > > > Could you please explain in the Changelog why we are migrating to GTask? > > ++
Carlos Garcia Campos
Comment 5 2013-06-19 00:34:27 PDT
Committed r151726: <http://trac.webkit.org/changeset/151726>
Note You need to log in before you can comment on or make changes to this bug.