Summary: | Remove 'activeSourceCount' from AudioContext and 'playbackState' from AudioBufferSourceNode and OscillatorNode IDLs. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Praveen Jadhav <praveen.j> | ||||||||
Component: | Web Audio | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | UNCONFIRMED --- | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, crogers, dev_sachin, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan | ||||||||
Priority: | P2 | Keywords: | WebExposed | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Praveen Jadhav
2013-06-03 05:32:09 PDT
Created attachment 203581 [details]
Patch
Comment on attachment 203581 [details]
Patch
LGTM.
Comment on attachment 203581 [details]
Patch
Thanks Praveen, we might as well also remove the .playbackState attribute, then we can remove the layout test completely.
We should write a more detailed test to replace it, using onended events
Created attachment 203683 [details]
Patch
Thanks Chris for the update. I have updated the code as per the comments. State machine in AudioScheduledSourceNode are not exposed to JS but retained for internal operations.
Created attachment 214443 [details]
Updated patch
Code updated.
Comment on attachment 203581 [details] Patch Cleared Chris Rogers's review+ from obsolete attachment 203581 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 214443 [details]
Updated patch
Assuming that patches for review since 2013 are stale, r-
|