Bug 117142

Summary: Remove 'activeSourceCount' from AudioContext and 'playbackState' from AudioBufferSourceNode and OscillatorNode IDLs.
Product: WebKit Reporter: Praveen Jadhav <praveen.j>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: cdumez, commit-queue, crogers, dev_sachin, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Updated patch beidson: review-

Praveen Jadhav
Reported 2013-06-03 05:32:09 PDT
Attribute 'activeSourceCount' is insignificant especially after including 'onended' events in source nodes. It has been removed from latest WebAudio spec https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section.
Attachments
Patch (9.00 KB, patch)
2013-06-03 06:28 PDT, Praveen Jadhav 		no flags
DetailsFormatted DiffDiff
Patch (19.90 KB, patch)
2013-06-04 05:05 PDT, Praveen Jadhav 		no flags
DetailsFormatted DiffDiff
Updated patch (19.88 KB, patch)
2013-10-17 05:04 PDT, Praveen Jadhav 		beidson: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Praveen Jadhav
Comment 1 2013-06-03 06:28:53 PDT
Created attachment 203581 [details] Patch
Chris Dumez
Comment 2 2013-06-03 06:40:34 PDT
Comment on attachment 203581 [details] Patch LGTM.
Chris Rogers
Comment 3 2013-06-03 10:42:46 PDT
Comment on attachment 203581 [details] Patch Thanks Praveen, we might as well also remove the .playbackState attribute, then we can remove the layout test completely. We should write a more detailed test to replace it, using onended events
Praveen Jadhav
Comment 4 2013-06-04 05:05:29 PDT
Created attachment 203683 [details] Patch Thanks Chris for the update. I have updated the code as per the comments. State machine in AudioScheduledSourceNode are not exposed to JS but retained for internal operations.
Praveen Jadhav
Comment 5 2013-10-17 05:04:47 PDT
Created attachment 214443 [details] Updated patch Code updated.
Csaba Osztrogonác
Comment 6 2014-02-13 04:04:48 PST
Comment on attachment 203581 [details] Patch Cleared Chris Rogers's review+ from obsolete attachment 203581 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Brady Eidson
Comment 7 2016-05-24 22:03:31 PDT
Comment on attachment 214443 [details] Updated patch Assuming that patches for review since 2013 are stale, r-
Note You need to log in before you can comment on or make changes to this bug.