Bug 117131

Summary: [WTF] Add OwnArrayPtr vectortraits template
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, darin, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105156    
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2013-06-02 22:11:43 PDT
Bug 105156 needs to use Vector<OwnArrayPtr<char>>. So, we need to add OwnArrayPtr to VectorTraits, which was guided in https://bugs.webkit.org/show_bug.cgi?id=105156#c39
Attachments
Patch (1.41 KB, patch)
2013-06-02 22:14 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-06-02 22:14:05 PDT
Created attachment 203553 [details] Patch
Gyuyoung Kim
Comment 2 2013-06-02 22:14:55 PDT
CC'ing Darin
Darin Adler
Comment 3 2013-06-02 23:05:04 PDT
Comment on attachment 203553 [details] Patch Looks OK. Might slow down compiles a bit since we are now including OwnArrayPtr in a lot of places that we weren’t before.
Gyuyoung Kim
Comment 4 2013-06-02 23:53:36 PDT
(In reply to comment #3) > (From update of attachment 203553 [details]) > Looks OK. Might slow down compiles a bit since we are now including OwnArrayPtr in a lot of places that we weren’t before. Thank you for review. It seems to me that this patch won't great influence on build time.
WebKit Commit Bot
Comment 5 2013-06-03 00:09:53 PDT
Comment on attachment 203553 [details] Patch Clearing flags on attachment: 203553 Committed r151093: <http://trac.webkit.org/changeset/151093>
WebKit Commit Bot
Comment 6 2013-06-03 00:09:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.