Bug 117117

Summary:

Unstyled XML viewer crashes when XML contains an element with id="tree"

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Web Inspector (Deprecated)

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, graouts, joepeck, rniwa, timothy

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	darin: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
patch for landing	none

Alexey Proskuryakov

Reported 2013-06-01 22:06:26 PDT

XML tree viewer that is used for unstyled XML combines the document with additional content, and then uses document.getElementById to find the additional content. This doesn't work correctly when the XML viewed has conflicting IDs. <rdar://problem/13727267>

Attachments
proposed fix (5.16 KB, patch) 2013-06-01 22:38 PDT, Alexey Proskuryakov	darin: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (464.25 KB, application/zip) 2013-06-02 00:16 PDT, Build Bot	no flags	Details
patch for landing (7.31 KB, patch) 2013-06-02 00:32 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2013-06-01 22:38:15 PDT

Created attachment 203502 [details] proposed fix This was done in such a strange way because there were Chromium extensions that duplicated this functionality, and Chromium folks wanted to give those a way to override built-in implementation. I could not find such extensions on extensions.apple.com. And in any case, I don't think that this is the approach we'd have taken if we wanted extensions to have this ability.

Darin Adler

Comment 2 2013-06-01 23:39:50 PDT

Comment on attachment 203502 [details] proposed fix OK.

Build Bot

Comment 3 2013-06-02 00:16:41 PDT

Comment on attachment 203502 [details] proposed fix Attachment 203502 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/765039 New failing tests: xmlviewer/extensions-api.html

Build Bot

Comment 4 2013-06-02 00:16:42 PDT

Created attachment 203506 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Alexey Proskuryakov

Comment 5 2013-06-02 00:32:50 PDT

Created attachment 203508 [details] patch for landing Oh good, I didn't find this test myself. Removing it, as the changes were intentional.

WebKit Commit Bot

Comment 6 2013-06-02 01:14:40 PDT

Comment on attachment 203508 [details] patch for landing Clearing flags on attachment: 203508 Committed r151080: <http://trac.webkit.org/changeset/151080>

WebKit Commit Bot

Comment 7 2013-06-02 01:14:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.