Bug 117076

Summary: Don't create an accelerated compositing layer unless we have to for snapshotting plug-ins
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, jonlee, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Dean Jackson
Reported 2013-05-31 08:14:53 PDT
https://bugs.webkit.org/show_bug.cgi?id=116490 changed the way snapshotting plugins can use accelerated compositing, allowing them to start in that mode before snapshotting. It turns out that this isn't a great user experience. So, for plugins that we know can support software-snapshotting, don't put them in compositing mode. <rdar://problem/14030364>
Attachments
Patch (5.18 KB, patch)
2013-05-31 08:19 PDT, Dean Jackson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-05-31 08:19:06 PDT
Created attachment 203448 [details] Patch
Dean Jackson
Comment 2 2013-05-31 09:46:10 PDT
Comments from Anders on IRC: - don't put the MIMETypeRegistry method in - use == rather than startsWith
Dean Jackson
Comment 3 2013-05-31 10:04:48 PDT
Committed r151026: <http://trac.webkit.org/changeset/151026>
Sam Weinig
Comment 4 2013-05-31 11:10:17 PDT
What exactly is broken here? You say that it "isn't a great user experience", but what does that mean? Can't we always use the CA path rather than the software snapshotting?
Note You need to log in before you can comment on or make changes to this bug.