Bug 117064

Summary: [WIN]Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste.
Product: WebKit Reporter: huangxueqing <huangxueqing>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch
bfulgham: review+
patch none

Description huangxueqing 2013-05-31 01:41:58 PDT
Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste.
Comment 1 huangxueqing 2013-05-31 02:11:04 PDT
Created attachment 203425 [details]
patch
Comment 2 Brent Fulgham 2013-05-31 22:38:55 PDT
Comment on attachment 203425 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review

This patch looks like a nice step in the right direction.  Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for.

> Source/WebCore/ChangeLog:11
> +        (WebCore::Editor::newGeneralClipboard):

Please add a note here describing what is changed.

> Source/WebCore/ChangeLog:13
> +        (WebCore::Pasteboard::createForCopyAndPaste):

Ditto.
Comment 3 huangxueqing 2013-06-02 19:10:15 PDT
Created attachment 203551 [details]
patch
Comment 4 huangxueqing 2013-06-02 19:11:02 PDT
(In reply to comment #2)
> (From update of attachment 203425 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review
> 
> This patch looks like a nice step in the right direction.  Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for.
> 
> > Source/WebCore/ChangeLog:11
> > +        (WebCore::Editor::newGeneralClipboard):
> 
> Please add a note here describing what is changed.
> 
Done

> > Source/WebCore/ChangeLog:13
> > +        (WebCore::Pasteboard::createForCopyAndPaste):
> 
> Ditto.
Done
Comment 5 huangxueqing 2013-06-05 19:03:36 PDT
Brent, please review this patch again, thanks.
Comment 6 WebKit Commit Bot 2013-06-05 21:13:06 PDT
Comment on attachment 203551 [details]
patch

Clearing flags on attachment: 203551

Committed r151253: <http://trac.webkit.org/changeset/151253>
Comment 7 WebKit Commit Bot 2013-06-05 21:13:08 PDT
All reviewed patches have been landed.  Closing bug.