Bug 117042 – REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility

[Anders Carlsson]

Created attachment 203377 [details]
Patch

[Mark Rowe (bdash)]

Comment on attachment 203377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203377&action=review

> Source/WebCore/loader/cache/CachedScript.cpp:116
> +    // The installer in question tries to load .js file that doesn't exist,/ causing the server to

There's a stray slash in this comment.

> Source/WebCore/platform/RuntimeApplicationChecks.cpp:114
> +    static bool isSolidStateNetworksDownloader = mainBundleIsEqualTo("com.solidstatenetworks.awkhost");
> +    return isSolidStateNetworksDownloader;

I'm not too keen on application specific hacks that never expire. With this hack in place they'd never notice the problem themselves and would have a hard time testing any fix on their end.

[Mark Rowe (bdash)]

Comment on attachment 203377 [details]
Patch

r=me anyway since I don't have any good ideas on how we could target the app specific hack more narrowly either.

[Anders Carlsson]

Committed r150977: <http://trac.webkit.org/changeset/150977>