Summary: | [Qt][WK1] Hover tests are flaky on Qt when running multiple tests at once | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Arvai <zarvai> | ||||||||
Component: | Tools / Tests | Assignee: | Radu Stavila <stavila> | ||||||||
Status: | RESOLVED INVALID | ||||||||||
Severity: | Normal | CC: | abrhm, allan.jensen, commit-queue, jturcotte, kadam, koivisto, ossy, stavila, WebkitBugTracker | ||||||||
Priority: | P2 | Keywords: | Qt | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 87008, 111749 | ||||||||||
Attachments: |
|
Description
Zoltan Arvai
2013-05-30 08:59:07 PDT
Created attachment 203562 [details]
Patch
Wasn't able to reproduce the problem on my Qt WK1 environment. I modified the test to overcome a possible issue with the hover check being carried out before the hover event could fire. If this patch will fix the main failing test, I will perform the same change for the other flaky tests.
Comment on attachment 203562 [details] Patch Clearing flags on attachment: 203562 Committed r151104: <http://trac.webkit.org/changeset/151104> All reviewed patches have been landed. Closing bug. fast/regions/hover-on-child-parent-different-regions.html unskipped in http://trac.webkit.org/changeset/151105. Reopen, because it still fails: --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/regions/hover-on-child-parent-different-regions-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/regions/hover-on-child-parent-different-regions-actual.txt @@ -1,4 +1,4 @@ -PASS Child hover event processed OK. +FAIL Child hover event FAILED to process. PASS Parent hover event processed OK. Created attachment 203607 [details]
Patch
The hover event seems to be triggered only AFTER the results are checked. Forced a re-layout in an attempt to fix this.
Created attachment 203611 [details]
Patch
Forced relayout to ensure hover event gets called before checking the results.
Something is wrong ... fast/regions/hover-on-child-parent-different-regions.html passes for me locally, but it fails on the bot. (I haven't run all the tests, only this one and then all fast/regions tests) Additionally fast/regions/hover-in-second-region.html fails if I run all fast/regions test, but passes if I run only this one. --> expected: 7xx is red, actual: 7xx is blue It seems it needs more debugging ... but now I have to go. Comment on attachment 203611 [details]
Patch
Let's see if this fixes the problem on the bots.
Comment on attachment 203611 [details] Patch Clearing flags on attachment: 203611 Committed r151121: <http://trac.webkit.org/changeset/151121> All reviewed patches have been landed. Closing bug. Still flaky, fails on http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r151168%20%2851497%29/results.html Skipped again in http://trac.webkit.org/changeset/151171. Probably the same issue as https://bugs.webkit.org/show_bug.cgi?id=117338 Looks like the Qt testing environment has some problems when running multiple hover tests in parallel (probably the multiple simultaneous calls to mouseMoveTo interfere with each other). *** Bug 117338 has been marked as a duplicate of this bug. *** I think part of the problem is that mouse-move events are not flushed in EventSenderQt. === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. |