Bug 117017

Summary:

Remove obsolete forward declaration from InspectorFrontendHost.h

Product:

WebKit

Reporter:

Seokju Kwon <seokju>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Seokju Kwon

Reported 2013-05-30 00:17:14 PDT

SSIA

Attachments
Patch (1.70 KB, patch) 2013-05-30 00:21 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Seokju Kwon

Comment 1 2013-05-30 00:19:31 PDT

Fix style issue as well. Source/WebCore/inspector/InspectorFrontendHost.h:105: The parameter name "client" adds no information, so it should be removed.

Seokju Kwon

Comment 2 2013-05-30 00:21:42 PDT

Created attachment 203314 [details] Patch

Joseph Pecoraro

Comment 3 2013-05-30 00:51:54 PDT

Comment on attachment 203314 [details] Patch There might be plenty of this in Inspector files. Removing unnecessary includes could even improve build times. This simple cleanup seems fine. r=me

Joseph Pecoraro

Comment 4 2013-05-30 00:52:27 PDT

Comment on attachment 203314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203314&action=review > Source/WebCore/ChangeLog:14 > + (WebCore): > + (InspectorFrontendHost): In the future, you can delete these lines from ChangeLogs. They are useless. I believe someone is working on fixing prepare-ChangeLog to no longer include them.

Seokju Kwon

Comment 5 2013-05-30 01:12:40 PDT

(In reply to comment #4) > (From update of attachment 203314 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203314&action=review > > > Source/WebCore/ChangeLog:14 > > + (WebCore): > > + (InspectorFrontendHost): > > In the future, you can delete these lines from ChangeLogs. They are useless. I believe someone is working on fixing prepare-ChangeLog to no longer include them. Ok. Thanks.

WebKit Commit Bot

Comment 6 2013-05-30 01:14:19 PDT

Comment on attachment 203314 [details] Patch Clearing flags on attachment: 203314 Committed r150953: <http://trac.webkit.org/changeset/150953>

WebKit Commit Bot

Comment 7 2013-05-30 01:14:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.