Summary: | Expose incrementalRenderingSuppressionTimeoutInSeconds via WK2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | Layout and Rendering | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, andersca, commit-queue, esprehn+autocc, japhet, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2013-05-29 22:36:05 PDT
Created attachment 203311 [details]
patch
Comment on attachment 203311 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203311&action=review > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:286 > +// Defaults to 5 seconds We put periods on these kinds of fragments, usually. > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:288 > +WK_EXPORT void WKPreferencesSetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef, double timeout); > +WK_EXPORT double WKPreferencesGetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef); Does “in seconds” really need to be in the function name? We use seconds for all our WebKit time units, don’t we? And it’s also the standard in Cocoa. Maybe the argument name would be sufficient? (In reply to comment #2) > (From update of attachment 203311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203311&action=review > > > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:286 > > +// Defaults to 5 seconds > > We put periods on these kinds of fragments, usually. Indeed! That file is amazingly inconsistent on this point. I'll add periods to mine. > > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:288 > > +WK_EXPORT void WKPreferencesSetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef, double timeout); > > +WK_EXPORT double WKPreferencesGetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef); > > Does “in seconds” really need to be in the function name? We use seconds for all our WebKit time units, don’t we? And it’s also the standard in Cocoa. Maybe the argument name would be sufficient? Probably not, I was just matching the WebCore setting name. I'll drop the InSeconds from the WK2 SPI. Thanks! |